[front-end] generate error or warning or info for undefined view model elements

🌎 Discussion in English
1

Does anybody know of a way to automatically generate front-end errors or at least some sort of warning if elements likeDivActionsForSelectedPlace are undefined in the frozen state?

image

If ClientIDs is undefined, of course it crashes but if it has value but does not contain DivActionsForSelectedPlace, it is silently ignored which is bad and needs treatment on each and every case.

PS:
also worthy of mention:
If accidentally I try to assign to / change a value in the frozen state by accident/unaware, it is silently ignored. Any idea on how to guard against this and somehow generate a message to Console tab? (The online docs warn about this and this is a good thing)

1 Like
2

Yea, this just returns undefined in javascript, I’d probably make a helper function for finding elements by id

function ensureElement(id) {
    const element = document.getElementById(id)
    if (!element) throw new Error(`Didn't find element ${id}`)
    return element
}

Or,you can declarefunction fail(msg) { throw new Error(msg) }, then the error handling at least simplifies to state.Ids.Whatever ?? fail('missing id')

Yes, use JS strict mode.

"use strict"
let x = Object.freeze({a:1})
x.a = 10 // throws error
1 Like
3

LE: So, it works in InlineScript control with your example. But it doesn’t with the dotvvm state.

image

I thought that dotvvm.state is already frozen. Puzzled.

PS:
dotvvm.state.OnClientComebackNullifyPopup = false also goes along silently.

4

UPDATE

Looks like I have to do this

image
image735Ă—151 10.7 KB

And it fails in Console tab as I desired:

image
image854Ă—68 6.39 KB

5

Oh shit, turns out we are not actually freezing the view model :man_facepalming: Thanks for helping us find out!

1 Like
6

sure, no prob

Please give me an update on this thread when a fix is launched, so I can reverse the “Object.freeze” extras.

7

We have fixed the Object.freeze bug in the 4.3.0-preview03-final version. We cannot release this as a 4.2 patch, since it could break someone. Version 4.3 should be compatible with 4.2 BP, bootstrap and other components (I hope they didn’t depend on the objects not being freezed :sweat_smile:)

1 Like
8

How do I install this 4.3.0-preview03-final ?

9

I’d just replace <PackageReference Include="DotVVM" Version="4.2.6" /> with <PackageReference Include="DotVVM" Version="4.3.0-preview03-final" />, but you should be able to install it with the Visual Studio NuGet GUI

10

No worries, sorry. I forgot to check “Include prerelease”

image
image1020Ă—213 10.3 KB

1 Like